feat: reverse_iterator support - #1474
Merged
Merged
Conversation
Contributor
Author
Note that this does not meet the requirements for ReversibleContainer. Since the current YAML::Node is also far away from Container (maybe it is never intended to be), I think this is acceptable. |
SGSSGene
approved these changes
Aug 10, 2026
SGSSGene
left a comment
SGSSGene
left a comment
Collaborator
There was a problem hiding this comment.
Amazing! cool feature!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
reverse_iteratorsupport forYAML::Node, including:Node::reverse_iteratorandNode::const_reverse_iteratorNode::rbegin()andNode::rend(), including const versionsI didn't do the same for
node_iterator, for I think node iterators won't be used directly and there're no systematic tests for node iterators.Currently
iterator_baseandnode_iterator_baseare incompatible withstd::reverse_iterator, since theiroperator->()function returns a proxy object, which could cause dangling pointer withstd::reverse_iterator. So I implemented a customizedreverse_iterator_basewrapper in yaml-cpp/node/detail/reverse_iterator.h .